Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pathParamsType to override behaviour when calling a generated get/post/put function #506

Merged
merged 4 commits into from
Oct 18, 2023
Merged

feat: pathParamsType to override behaviour when calling a generated get/post/put function #506

merged 4 commits into from
Oct 18, 2023

Conversation

stijnvanhulle
Copy link
Collaborator

@stijnvanhulle stijnvanhulle commented Oct 18, 2023 •
edited
Loading

  • Test case for asObject in getParamsAsAST

@vercel
Copy link

vercel bot commented Oct 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kubb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 4:54pm

@stijnvanhulle stijnvanhulle linked an issue Oct 18, 2023 that may be closed by this pull request
Allow using an object for path params #501
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 18, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2da4c7a:

Sandbox Source
advanced-pet-store Configuration
faker-pet-store Configuration
msw-pet-store Configuration
react-query-pet-store Configuration
react-query-v5-pet-store Configuration
typescript-pet-store Configuration
simple-single-pet-store Configuration
solid-query-pet-store Configuration
svelte-query-pet-store Configuration
swr-pet-store Configuration
vue-query-pet-store Configuration
zod-pet-store Configuration
zodios-pet-store Configuration
client-pet-store Configuration

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #506 (2da4c7a) into main (a08cd67) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   85.71%   85.74%   +0.03%     
==========================================
  Files         112      112              
  Lines        6412     6426      +14     
  Branches      807      811       +4     
==========================================
+ Hits         5496     5510      +14     
  Misses        915      915              
  Partials        1        1
Files Coverage Δ
packages/core/src/utils/FunctionParams.ts 94.04% <100.00%> (ø)
packages/swagger/src/utils/getParams.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stijnvanhulle stijnvanhulle merged commit f6ad26a into main Oct 18, 2023
8 checks passed
@stijnvanhulle stijnvanhulle deleted the feat/pathParamsType branch October 18, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow using an object for path params
1 participant
@stijnvanhulle